xuzifu666 commented on code in PR #4771:
URL: https://github.com/apache/calcite/pull/4771#discussion_r2726853827
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -1868,6 +1868,7 @@ void testCastToBoolean(CastType castType,
SqlOperatorFixture f) {
"INTEGER ARRAY");
f.checkScalar("cast(cast('abc' as VARIANT) AS VARCHAR)", "abc", "VARCHAR");
f.checkScalar("cast(cast('abc' as VARIANT) AS CHAR(3))", "abc", "CHAR(3)");
+ f.checkScalar("cast(cast(2147483648 as VARIANT) as DECIMAL)",
"2147483648", "DECIMAL(19, 0)");
Review Comment:
I think the bug fix way is OKļ¼but please note:
1. Your commit message should not contain words like "Fix," and you need to
modify the Jira link content to match the PR.
2. It is recommended to add the corresponding JIRA info to the
```testCastToBoolean``` method, or you can add the corresponding comment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
