xuzifu666 commented on PR #4784: URL: https://github.com/apache/calcite/pull/4784#issuecomment-3846954563
> I'm not an expert in ClickHouse, but [the documentation](https://clickhouse.com/docs/sql-reference/functions/url-functions) suggests ClickHouse calls these functions `encodeURLComponent` and `decodeURLComponent`. Since we're talking about changes to the ClickHouse dialect, it would be good to match these names. @michaelmior Thank you for the suggestion. Here's my understanding: this PR mainly addresses two things: 1. It enables the ClickHouse Library to recognize the ```url_encode``` and ```url_decode``` functions; 2. It accurately converts SQL from Calcite to the correct ClickHouse dialect, as explained in the documentation, for example, converting ```url_encode``` to ```encodeURLComponent```. Since this name is specific to the ClickHouse dialect, it seems unnecessary to introduce a function with the same implementation but a different name. This can be seen in ```RelToSqlConvertTest```, where the dialect-converted name is correct. I wonder if you agree with my point of view. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
