mihaibudiu commented on code in PR #4789: URL: https://github.com/apache/calcite/pull/4789#discussion_r2777907504
########## redis/src/main/java/redis/embedded/util/JarUtil.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package redis.embedded.util; + +import org.apache.commons.io.FileUtils; + +import com.google.common.io.Resources; + +import java.io.File; +import java.io.IOException; +import java.nio.file.Files; + +/** Utility class for extracting executables from JAR files. */ +public class JarUtil { + + private JarUtil() { + // Utility class should not be instantiated + } + + public static File extractExecutableFromJar(String executable) throws IOException { + File tmpDir = Files.createTempDirectory("redis-").toFile(); + tmpDir.deleteOnExit(); + + // On newer versions of macOS, the temporary directory /var/folders does not + // support executing binary files with a .app extension, which prevents Redis + // from starting. To ensure Redis runs correctly, the redis-server binary is + // uniformly renamed to edis-server. Review Comment: typo ########## redis/src/main/java/redis/embedded/util/JarUtil.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package redis.embedded.util; + +import org.apache.commons.io.FileUtils; + +import com.google.common.io.Resources; + +import java.io.File; +import java.io.IOException; +import java.nio.file.Files; + +/** Utility class for extracting executables from JAR files. */ +public class JarUtil { + + private JarUtil() { + // Utility class should not be instantiated + } + + public static File extractExecutableFromJar(String executable) throws IOException { + File tmpDir = Files.createTempDirectory("redis-").toFile(); + tmpDir.deleteOnExit(); + + // On newer versions of macOS, the temporary directory /var/folders does not + // support executing binary files with a .app extension, which prevents Redis + // from starting. To ensure Redis runs correctly, the redis-server binary is + // uniformly renamed to edis-server. + String executableName = "redis-server"; + File command = new File(tmpDir, executableName); + System.out.println("Executing " + command.getAbsolutePath()); Review Comment: Is this print supposed to be here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
