mihaibudiu commented on code in PR #4797:
URL: https://github.com/apache/calcite/pull/4797#discussion_r2830579137
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -3307,6 +3307,75 @@ static void checkOverlaps(OverlapChecker c) {
c.isTrue("($3,$0) IMMEDIATELY SUCCEEDS ($0,$0)");
}
+ /** Test cases for <a
href="https://issues.apache.org/jira/browse/CALCITE-7418";>[CALCITE-7418]
+ * SqlOverlapsOperator does not reject some illegal comparisons (e.g., TIME
vs DATE)</a>. */
+ @Test void testNegativePeriodOperators() {
+ final String containsError = "Supported form\\(s\\): "
+ + "'\\(<DATE/TIME/TIMESTAMP>, <DATE/TIME/TIMESTAMP>\\) CONTAINS "
Review Comment:
This message is generated by calling `getAllowedSignatures()`. I will check
whether I can improve it, but in general the format is rather constrained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
