wForget commented on code in PR #4816:
URL: https://github.com/apache/calcite/pull/4816#discussion_r2875926154
##########
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##########
@@ -1410,6 +1410,32 @@ private void checkLarge(int n) {
.ok("VALUES (ROW((`A` BETWEEN ASYMMETRIC ((`B` OR (`C` AND `D`)) OR
`E`) AND `F`)))");
}
+ @Test void testBetweenInverse() throws Exception {
Review Comment:
new test case:
```
@Test void testBetween() {
ReflectiveConvertletTable convertletTable =
StandardConvertletTable.INSTANCE;
// reflect to remove between from map
try {
Field field = ReflectiveConvertletTable.class.getDeclaredField("map");
field.setAccessible(true);
Map<Object, Object> map = (Map<Object, Object>)
field.get(convertletTable);
map.remove(SqlBetweenOperator.class);
} catch (Exception e) {
throw new RuntimeException(e);
}
final String query = "SELECT empno FROM emp WHERE sal BETWEEN 1000 AND
2000";
sql(query).ok();
}
```
error:
```
[0;31;1mFAILURE[0m 0.3sec,
org.apache.calcite.test.[0;1mSqlToRelConverterTest[0m >
[0;1mtestBetween()[0m
java.lang.AssertionError: not a rex operator
at org.apache.calcite.util.Litmus.lambda$static$0(Litmus.java:31)
at
org.apache.calcite.sql.fun.SqlBetweenOperator.validRexOperands(SqlBetweenOperator.java:115)
at org.apache.calcite.rex.RexCall.<init>(RexCall.java:93)
at org.apache.calcite.rex.RexBuilder.makeCall(RexBuilder.java:293)
at
org.apache.calcite.sql2rel.StandardConvertletTable.convertCall(StandardConvertletTable.java:1250)
at
org.apache.calcite.sql2rel.ReflectiveConvertletTable.lambda$registerNodeTypeMethod$1(ReflectiveConvertletTable.java:95)
at
org.apache.calcite.sql2rel.SqlNodeToRexConverterImpl.convertCall(SqlNodeToRexConverterImpl.java:62)
at
org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:6118)
at
org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:5280)
at org.apache.calcite.sql.SqlCall.accept(SqlCall.java:175)
at
org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.convertExpression(SqlToRelConverter.java:5932)
at
org.apache.calcite.sql2rel.SqlToRelConverter.convertWhere(SqlToRelConverter.java:1234)
at
org.apache.calcite.sql2rel.SqlToRelConverter.convertSelectImpl(SqlToRelConverter.java:797)
at
org.apache.calcite.sql2rel.SqlToRelConverter.convertSelect(SqlToRelConverter.java:738)
at
org.apache.calcite.sql2rel.SqlToRelConverter.convertQueryRecursive(SqlToRelConverter.java:4123)
at
org.apache.calcite.sql2rel.SqlToRelConverter.convertQuery(SqlToRelConverter.java:631)
at
org.apache.calcite.sql.test.AbstractSqlTester.convertSqlToRel2(AbstractSqlTester.java:570)
at
org.apache.calcite.sql.test.AbstractSqlTester.assertSqlConvertsTo(AbstractSqlTester.java:511)
at
org.apache.calcite.sql.test.AbstractSqlTester.assertConvertsTo(AbstractSqlTester.java:489)
at
org.apache.calcite.test.SqlToRelFixture.convertsTo(SqlToRelFixture.java:106)
at
org.apache.calcite.test.SqlToRelFixture.ok(SqlToRelFixture.java:94)
[0;1mat
org.apache.calcite.test.SqlToRelConverterTest.testBetween(SqlToRelConverterTest.java:6066)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
