cjj2010 commented on code in PR #4837: URL: https://github.com/apache/calcite/pull/4837#discussion_r2937868213
########## core/src/main/java/org/apache/calcite/sql/fun/SqlNullifFunction.java: ########## @@ -1,73 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to you under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package org.apache.calcite.sql.fun; - -import org.apache.calcite.sql.SqlCall; -import org.apache.calcite.sql.SqlFunction; -import org.apache.calcite.sql.SqlFunctionCategory; -import org.apache.calcite.sql.SqlKind; -import org.apache.calcite.sql.SqlLiteral; -import org.apache.calcite.sql.SqlNode; -import org.apache.calcite.sql.SqlNodeList; -import org.apache.calcite.sql.parser.SqlParserPos; -import org.apache.calcite.sql.type.OperandTypes; -import org.apache.calcite.sql.type.ReturnTypes; -import org.apache.calcite.sql.validate.SqlValidator; - -import java.util.List; - -/** - * The <code>NULLIF</code> function. - */ -public class SqlNullifFunction extends SqlFunction { Review Comment: Okay, I have already replied to Jira. From the current situation, Calcite will directly convert nullif to casewhen by default. I think there are two solutions at present: 1. If there is an aggregation function, it will not be converted to casewhen; 2. Keep nullif in all cases and add optimization rules, such as NULLIF(x + 1, 5), we use common subexpression elimination so that the argument "x + 1" is only evaluated once @mihaibudiu @xiedeyantu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
