xiedeyantu commented on code in PR #4845:
URL: https://github.com/apache/calcite/pull/4845#discussion_r3001382102
##########
core/src/main/java/org/apache/calcite/sql2rel/ConvertToChecked.java:
##########
@@ -38,8 +38,8 @@
public class ConvertToChecked extends RelHomogeneousShuttle {
final ConvertRexToChecked converter;
- public ConvertToChecked(RexBuilder builder) {
Review Comment:
Should we add an
"@Deprecated" annotation here to preserve the original method?
##########
core/src/test/resources/sql/scalar.iq:
##########
@@ -18,6 +18,32 @@
!set outputformat mysql
!use scott
+# 5 test cases for [CALCITE-7443] Incorrect simplification for large interval
+SELECT -(INTERVAL -2147483648 months);
+java.lang.ArithmeticException: integer overflow
Review Comment:
"java.lang.ArithmeticException: INTERVAL MONTH value out of integer range"
Can the error message be made more informative? For example, when
encountering an error in a complex SQL, it might be difficult to quickly
pinpoint the exact location. Could we even include the specific number in the
error message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
