xiedeyantu commented on code in PR #4856:
URL: https://github.com/apache/calcite/pull/4856#discussion_r3026421810
##########
core/src/main/java/org/apache/calcite/sql/dialect/MssqlSqlDialect.java:
##########
@@ -172,6 +172,13 @@ public MssqlSqlDialect(Context context) {
final SqlWriter.Frame frame = writer.startFunCall("CEILING");
call.operand(0).unparse(writer, leftPrec, rightPrec);
writer.endFunCall(frame);
+ } else if (call.getKind() == SqlKind.SAFE_CAST) {
Review Comment:
I researched other dialects, and they almost all use `writer.startFunCall`
to rewrite functions. I am not sure this is good way, but this is the current
reality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
