xuzifu666 commented on PR #4874: URL: https://github.com/apache/calcite/pull/4874#issuecomment-4229343649
> mostly LGTM the question I have is whether it makes sense to consider test cases with ordinals and aliases like `SqlConformance#isGroupByAlias` and `SqlConformance#isGroupByOrdinal`, same for `ORDER BY` Thanks for the review @snuyanzin . I have added additional test cases; the current set of tests should now be sufficient to verify the fix for CALCITE-4868, for the following reasons: 1. The bug in question concerns a failure in the Elasticsearch adapter triggered specifically when an `ORDER BY` clause follows a `GROUP BY` clause. 2. The current tests successfully verify the core functionality: that aggregation combined with `ORDER BY` aliases works correctly. 3. Different SQL conformance settings primarily influence how aliases and ordinals are processed during the parsing phase, whereas the fix for the Elasticsearch adapter addresses the sorting logic during the execution phase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
