snuyanzin commented on code in PR #4889:
URL: https://github.com/apache/calcite/pull/4889#discussion_r3089583043
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/MatchUtils.java:
##########
@@ -27,21 +27,22 @@ private MatchUtils() {
}
/**
- * Returns the row with the highest index whose corresponding symbol
matches, null otherwise.
+ * Returns the row with the highest index whose corresponding symbol matches,
+ * row with defaultIndex otherwise.
*
* @param symbol Target Symbol
* @param rows List of passed rows
* @param symbols Corresponding symbols to rows
- * @return index or -1
+ * @return index or defaultIndex
*/
- public static <E> int lastWithSymbol(String symbol, List<E> rows,
List<String> symbols,
- int startIndex) {
+ public static <E> int lastWithSymbolOrDefault(String symbol, List<E> rows,
List<String> symbols,
Review Comment:
>maybe you can just use a new one.
good point, reverted changes for existing and created a new one with removed
unused args
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
