julianhyde commented on code in PR #4947:
URL: https://github.com/apache/calcite/pull/4947#discussion_r3250483011
##########
core/src/main/java/org/apache/calcite/sql/type/BasicSqlType.java:
##########
@@ -76,6 +76,20 @@ public BasicSqlType(RelDataTypeSystem typeSystem,
SqlTypeName typeName,
int precision) {
this(typeSystem, typeName, false, precision, SCALE_NOT_SPECIFIED, null,
null);
+ }
+
+ /**
+ * Constructs a type with precision/length and scale.
Review Comment:
Worse than that, the change you have made isn't consistent with the commit
message. Sort it out, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]