xuzifu666 commented on code in PR #4949:
URL: https://github.com/apache/calcite/pull/4949#discussion_r3270831548
##########
core/src/test/java/org/apache/calcite/test/MaterializedViewRelOptRulesTest.java:
##########
@@ -251,6 +251,44 @@ protected final MaterializedViewFixture sql(String
materialize,
.ok();
}
+ /** Test case for <a
href="https://issues.apache.org/jira/browse/CALCITE-7534";>[CALCITE-7534]
+ * Support GROUPING SETS, CUBE and ROLLUP in materialized view aggregate
rule rewriting</a>. */
+ @Test void testAggregateGroupSets1() {
Review Comment:
The original tests only showed the rewritten plan (after materialized view
matching), which made it hard to understand what optimization was actually
being tested.So I added Javadoc showing the changes in the plan before and
after. Does this achieve the desired result? @mihaibudiu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
