xiedeyantu commented on PR #4925: URL: https://github.com/apache/calcite/pull/4925#issuecomment-4544786887
Thank you for the contribution @wg1026688210 ! Although I don't know much about Milvus, I think this adapter is very valuable. As @zabetak stated in CALCITE-6908, the test coverage of the milvus adaptor should ideally reach 80%. I suggest including test cases along with the feature descriptions and adding the test cases mentioned in the descriptions to the code. This will make it easier for reviewers to review the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
