darpan-e6 commented on code in PR #4970:
URL: https://github.com/apache/calcite/pull/4970#discussion_r3315343197
##########
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##########
@@ -6133,4 +6133,16 @@ void checkUserDefinedOrderByOver(NullCollation
nullCollation) {
+ "FROM emp JOIN dept using (deptno)";
sql(sql).withConformance(SqlConformanceEnum.PRESTO).ok();
}
+
+ /** Test case of
Review Comment:
Because `SqlToRelConverter` builds its `RelNode` tree through `RelBuilder`,
and `RelBuilder` eagerly merges adjacent projects at construction time using
the same helper that the planner rules use.
Concretely, `RelBuilder.project_` method uses the method
`RelOptUtil.pushPastProjectUnlessBloat(nodeList, project, config.bloat())` and
this is the method in which we are putting the fix, so I thought of putting a
test here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
