xiedeyantu commented on code in PR #4981:
URL: https://github.com/apache/calcite/pull/4981#discussion_r3333063212
##########
core/src/test/java/org/apache/calcite/sql2rel/RelDecorrelatorTest.java:
##########
@@ -2124,4 +2124,85 @@ public static Frameworks.ConfigBuilder config() {
+ " LogicalTableScan(table=[[scott, DEPT]])\n";
assertThat(afterDecorrelation, hasTree(planAfterDecorrelation));
}
+
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-7574";>[CALCITE-7574]
+ * IndexOutOfBoundsException in RelDecorrelator.isFieldNotNullRecursive
+ * when checking Aggregate result fields</a>.
+ *
+ * <p>When decorrelating a correlated scalar subquery containing an
Aggregate,
+ * {@code isFieldNotNullRecursive} incorrectly used {@code
ImmutableBitSet.size()}
+ * (which returns the bitset capacity, typically 64 * words) instead of
+ * {@code Aggregate.getGroupCount()} (which returns the number of group
keys).
+ * This caused an {@code IndexOutOfBoundsException} when the field index
+ * corresponded to an aggregate result field (not a group field).
+ */
+ @Test void testDecorrelateScalarSubQueryWithAggregate() {
+ final FrameworkConfig frameworkConfig = config().build();
+ final RelBuilder builder = RelBuilder.create(frameworkConfig);
+ final RelOptCluster cluster = builder.getCluster();
+ final Planner planner = Frameworks.getPlanner(frameworkConfig);
+ // Minimal case: outer FROM is an Aggregate, correlated subquery
+ // references the aggregate result field (s) in the correlation
+ // condition, triggering isFieldNotNullRecursive on an Aggregate with
+ // an index pointing to an aggregate result field.
+ final String sql = "select t.deptno,\n"
+ + " (select count(*) from emp e\n"
Review Comment:
Yes, `sub-query.iq` may be the better place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
