xuzifu666 commented on code in PR #4983:
URL: https://github.com/apache/calcite/pull/4983#discussion_r3338227911
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/PhysTypeImpl.java:
##########
@@ -276,9 +276,15 @@ static PhysType of(
final Expression selector;
if (collations.size() == 1) {
RelFieldCollation collation = collations.get(0);
+ final int index = collation.getFieldIndex();
+ if (index < 0 || index >= rowType.getFieldList().size()) {
Review Comment:
Yes, this is just a defensive check, but it seems unnecessary now, so I
deleted it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
