OldTruckDriver opened a new pull request, #4986:
URL: https://github.com/apache/calcite/pull/4986

   `SqlParserUtil.parseTimeTzLiteral(...)` used `TimeZone.getTimeZone(String)`, 
which silently falls back to GMT for unknown zone IDs, so invalid `TIME WITH 
TIME ZONE` literals were accepted instead of rejected. The sibling 
`parseTimestampTzLiteral(...)` already validates the zone via `ZoneId.of(...)`.
   
   This applies the same pattern as CALCITE-7527: validate the zone with 
`ZoneId.of(...)` and throw a `CalciteContextException` on an invalid zone, 
making the two paths consistent.
   
   Added `SqlParserUtilTest.testTimeWithTimeZone` covering a valid zone, an 
unknown zone, and a missing zone.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to