xiedeyantu commented on code in PR #4897:
URL: https://github.com/apache/calcite/pull/4897#discussion_r3361180495
##########
core/src/test/java/org/apache/calcite/test/RelBuilderTest.java:
##########
@@ -2577,6 +2707,55 @@ private static RelNode groupIdRel(RelBuilder builder,
boolean extra) {
assertThat(root, hasTree(expected));
}
+ @ParameterizedTest
Review Comment:
To address this, I added test cases involving the `ROW` type for the three
`SetOp` operators. This is necessary because the `ROW` type imposes specific
constraints regarding nullability: when the `ROW` itself is `NOT NULL`, its
internal fields can be either nullable or `NOT NULL`; conversely, when the
`ROW` is `NULL`, all its internal fields must also be `NULL`. For the
`INTERSECT` operator, I used a `NOT NULL` outer `ROW` to observe the tightening
of the internal fields' nullability attributes. For the `UNION` operator, I
used a `NULL` outer `ROW` to observe the relaxation of nullability attributes
for both the internal fields and the outer `ROW` itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
