davidradl commented on code in PR #4994:
URL: https://github.com/apache/calcite/pull/4994#discussion_r3362634392


##########
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##########
@@ -570,6 +570,17 @@ && consecutiveSameCharCountBefore(str, start - 1, escape) 
% 2 == 1) {
     return builder.toString();
   }
 
+  private static Pattern getWildCardPattern(char escape) {
+    switch (escape) {
+    case '%':
+      return Pattern.compile("_+");

Review Comment:
   am I missing something - it looks like the case bodies are the wrong way 
round. % uses a Pattern with an underscore  and underscore uses a pattern with  
%



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to