xuzifu666 commented on code in PR #5004:
URL: https://github.com/apache/calcite/pull/5004#discussion_r3385320062


##########
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##########
@@ -5977,6 +6038,106 @@ private CalciteAssert.AssertQuery withEmpDept(String 
sql) {
         Matchers.returnsUnordered("name=Eric"));
   }
 
+  /** Tests dynamic parameters in parenthesized FETCH expressions. */
+  @Test void testPreparedFetchExpression() throws Exception {
+    CalciteAssert.that()
+        .doWithConnection(connection -> {
+          final String values =
+              "select * from (values (1), (2), (3), (4)) as t(x)\n";
+          checkPreparedFetch(connection, values + "fetch next (?) rows only",
+              2, "X=1\nX=2\n");
+          checkPreparedFetch(connection, values + "fetch next (? + 1) rows 
only",

Review Comment:
   I also have questions about this; perhaps I should add some details on how 
to address this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to