xiedeyantu commented on PR #5013: URL: https://github.com/apache/calcite/pull/5013#issuecomment-4676413612
> > There's another point worth discussing: should we have the parser in Core directly support this capability, should it also be placed in Babel, or should the original SELECT * EXCLUDE also be supported by default in Core's parser? I don't have a strong preference — I'm just wondering whether the two should be unified. > > For now the plan is to support it whenever ROW(*) is supported. Agree! Currently, this is directly supported in the core rather than being controlled via the `includeStarExclude` parameter in Babel; I think we could either bring this feature under the control of `includeStarExclude` or remove `includeStarExclude` entirely. I tested enabling `includeStarExclude` (`includeStarExclude: true`), but I'm currently getting an error. ``` /calcite/sql/parser/impl/SqlParserImpl.java:5223: error: variable sqlIdentifier is already defined in method SelectExpression() final SqlIdentifier sqlIdentifier = (SqlIdentifier) e; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
