zzwqqq commented on code in PR #5017:
URL: https://github.com/apache/calcite/pull/5017#discussion_r3406872051


##########
core/src/main/java/org/apache/calcite/sql/SqlUtil.java:
##########
@@ -455,48 +455,62 @@ public static void unparseBinarySyntax(
   }
 
   /**
-   * Unparses a WHERE clause.
+   * Unparses a condition clause, such as WHERE or ON.
    *
    * <p>Unparsing the condition in a {@link SqlWriter.FrameTypeEnum#WHERE_LIST}
    * frame lets sub-queries in predicates recognize that they need
    * parentheses.
    *
-   * @param writer   Writer
-   * @param where WHERE condition
+   * @param writer Writer
+   * @param clauseKeyword Clause keyword
+   * @param condition Clause condition
    * @param leftPrec Left precedence
    * @param rightPrec Right precedence
    */
-  public static void unparseWhereClause(SqlWriter writer, SqlNode where,
-      int leftPrec, int rightPrec) {
-    writer.sep("WHERE");
+  public static void unparseConditionClause(SqlWriter writer,

Review Comment:
   Thanks, I removed the clauseKeyword parameter and the unparseWhereClause 
wrapper.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to