mihaibudiu commented on code in PR #5019:
URL: https://github.com/apache/calcite/pull/5019#discussion_r3422955650
##########
site/_docs/reference.md:
##########
@@ -2116,9 +2108,11 @@ Syntax:
windowedAggregateCall:
agg '(' [ ALL | DISTINCT ] value [, value ]* ')'
[ RESPECT NULLS | IGNORE NULLS ]
+ [ FILTER '(' WHERE condition ')' ]
Review Comment:
Can you also add to this documentation the information you added to the JIRA
issue about the order of application of the FILTER?
##########
core/src/test/resources/sql/winagg.iq:
##########
@@ -1173,4 +1173,116 @@ order by 1;
(14 rows)
!ok
+
+# [CALCITE-6442] Support FILTER clause with window functions
Review Comment:
Please add here the following:
- next 4 tests are related to this issue
- results were validated on Postgres
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
