mihaibudiu commented on code in PR #5026:
URL: https://github.com/apache/calcite/pull/5026#discussion_r3437494127
##########
core/src/main/java/org/apache/calcite/sql/SqlSelectOperator.java:
##########
@@ -152,8 +153,14 @@ public SqlSelect createCall(
}
writer.topN(select.fetch, select.offset);
final SqlNodeList selectClause = select.selectList;
- writer.list(SqlWriter.FrameTypeEnum.SELECT_LIST, SqlWriter.COMMA,
- selectClause);
+ if (writer.getDialect().alwaysUseExprAlias()) {
Review Comment:
This doesn't really change the plan, only the way the plan is unparsed.
A "real" implementation would allocate names for aggregates in the validator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
