mihaibudiu commented on PR #5050: URL: https://github.com/apache/calcite/pull/5050#issuecomment-4811666909
In general we should push as much as possible in the validation and code generation layers. If the runtime does not support fractional values, the code generation should generate a rounding operation. I would pick a reasonable implementation and do that, if other people need different semantics, they can file issues or override behaviors. Every new configuration flag increases exponentially the test surface, so I would avoid them unless they are really needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
