xiedeyantu commented on code in PR #5067:
URL: https://github.com/apache/calcite/pull/5067#discussion_r3506045603
##########
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##########
@@ -5500,27 +5500,42 @@ private CalciteAssert.AssertQuery predicate(String foo)
{
/** Test case for
* <a href="https://issues.apache.org/jira/browse/CALCITE-685";>[CALCITE-685]
* Correlated scalar sub-query in SELECT clause throws</a>. */
- @Disabled("[CALCITE-685]")
@Test void testCorrelatedScalarSubQuery() {
final String sql = "select e.department_id, sum(e.employee_id),\n"
+ " ( select sum(e2.employee_id)\n"
+ " from employee e2\n"
+ " where e.department_id = e2.department_id\n"
+ " )\n"
+ "from employee e\n"
- + "group by e.department_id\n";
- final String explain = "EnumerableNestedLoopJoin(condition=[true],
joinType=[left])\n"
- + " EnumerableAggregate(group=[{7}], EXPR$1=[$SUM0($0)])\n"
- + " EnumerableTableScan(table=[[foodmart2, employee]])\n"
- + " EnumerableAggregate(group=[{}], EXPR$0=[SUM($0)])\n"
- + " EnumerableCalc(expr#0..16=[{inputs}], expr#17=[$cor0],
expr#18=[$t17.department_id], expr#19=[=($t18, $t7)], employee_id=[$t0],
department_id=[$t7], $condition=[$t19])\n"
- + " EnumerableTableScan(table=[[foodmart2, employee]])\n";
+ + "group by e.department_id\n"
+ + "order by e.department_id";
+ final String explain = "EnumerableCalc(expr#0..3=[{inputs}],
proj#0..1=[{exprs}], "
+ + "EXPR$0=[$t3])\n"
+ + " EnumerableMergeJoin(condition=[=($0, $2)], joinType=[left])\n"
+ + " EnumerableSort(sort0=[$0], dir0=[ASC])\n"
+ + " EnumerableAggregate(group=[{7}], EXPR$1=[$SUM0($0)])\n"
+ + " EnumerableTableScan(table=[[foodmart2, employee]])\n"
+ + " EnumerableSort(sort0=[$0], dir0=[ASC])\n"
+ + " EnumerableAggregate(group=[{7}], EXPR$0=[$SUM0($0)])\n"
+ + " EnumerableTableScan(table=[[foodmart2, employee]])\n";
CalciteAssert.that()
.with(CalciteAssert.Config.FOODMART_CLONE)
.with(Lex.JAVA)
.query(sql)
.explainContains(explain)
- .returnsCount(0);
+ .returnsOrdered(
Review Comment:
pgsql result: https://onecompiler.com/postgresql/44tx3m774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
