snuyanzin commented on code in PR #5078:
URL: https://github.com/apache/calcite/pull/5078#discussion_r3524583618


##########
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##########
@@ -8549,6 +8544,33 @@ void testGroupExpressionEquivalenceParams() {
         .type("RecordType(INTEGER NOT NULL C, INTEGER NOT NULL D) NOT NULL");
   }
 
+  /** Test case for
+   * <a 
href="https://issues.apache.org/jira/browse/CALCITE-6036";>[CALCITE-6036]
+   * Support WITHIN GROUP (ORDER BY x) OVER (PARTITION BY y)</a>. Combining a
+   * WITHIN GROUP clause with an OVER clause is non-standard (Oracle) syntax 
that
+   * is only allowed under a conformance that enables it, such as BABEL. */
+  @Test void testPercentileWithinGroupOver() {
+    final String sql = "select\n"

Review Comment:
   would be great also having tests for unparsing especially if there is 
expression under `order by` /`partition by`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to