anxkhn opened a new pull request, #5085:
URL: https://github.com/apache/calcite/pull/5085

   
   ## Jira Link
   
   N/A. Per this repository's pull request template, a Jira issue is not 
required
   for typos and cosmetic changes (changes that are neither bugs nor features).
   This is a one-character typo in an internal exception message.
   
   ## Changes Proposed
   
   `TableNamespace.extend(...)` builds a lazy message for the
   `Objects.requireNonNull` guard that fires when a `RelOptTable` cannot be
   unwrapped to a `SqlValidatorTable`. That message reads `cant unwrap
   SqlValidatorTable from ...`; `cant` should be `can't`.
   
   ```diff
                relOptTable.unwrap(SqlValidatorTable.class),
   -            () -> "cant unwrap SqlValidatorTable from " + relOptTable);
   +            () -> "can't unwrap SqlValidatorTable from " + relOptTable);
   ```
   
   The sibling guard a few lines below, in `getBaseRowType()`, already uses the
   correct spelling (`"can't unwrap Table from "`), so this change simply makes 
the
   two messages in the same file consistent. It is text-only: no behavior, 
control
   flow, or overload resolution changes.
   
   No test is added: the string is an internal null-check message on a 
hard-to-reach
   invariant path, and Calcite does not unit-test these guard messages. 
`./gradlew
   build` passes; `autostyleApply` reports no changes and `checkstyleMain` is 
clean.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to