julianhyde commented on code in PR #5074:
URL: https://github.com/apache/calcite/pull/5074#discussion_r3537997732
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/AggImpState.java:
##########
@@ -35,10 +35,22 @@ public class AggImpState {
public @MonotonicNonNull List<Expression> state;
public @MonotonicNonNull Expression accumulatorAdder;
+ /**
+ * Creates an AggImpState, resolving the implementor from the built-in table.
+ *
+ * @deprecated Use {@link #AggImpState(int, AggregateCall, boolean,
RexImplementorTable)}.
+ */
+ @Deprecated // to be removed before 2.0
public AggImpState(int aggIdx, AggregateCall call, boolean windowContext) {
+ this(aggIdx, call, windowContext, RexImpTable.INSTANCE);
+ }
+
+ public AggImpState(int aggIdx, AggregateCall call, boolean windowContext,
+ RexImplementorTable implementorTable) {
Review Comment:
Why is `implementorTable` a constructor parameter when it does not become a
field? Why not use a constructor method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
