xiedeyantu commented on PR #5050: URL: https://github.com/apache/calcite/pull/5050#issuecomment-4920092119
That sounds good to me! I took a careful look at this PR. It removes the configuration option while preserving the rounding behavior by choosing one strategy as the default. The tests all look as expected. Unless there are any additional concerns, I think this PR can be squashed and is ready to be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
