xuzifu666 commented on code in PR #5089:
URL: https://github.com/apache/calcite/pull/5089#discussion_r3555886212


##########
core/src/test/resources/sql/agg.iq:
##########
@@ -4301,4 +4301,19 @@ GROUP BY GROUPING SETS ((deptno), ());
 
 !ok
 
+# [CALCITE-7647] GROUP BY ALL expands SELECT * to every underlying column;
+# the star columns become grouping keys and the aggregate is excluded
+select *, count(*) as c from (values (1, 'a'), (1, 'a'), (2, 'b')) as t(x, y)

Review Comment:
   I would like to know if this has been verified through specific database 
testing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to