xuzifu666 commented on code in PR #5086:
URL: https://github.com/apache/calcite/pull/5086#discussion_r3565840669
##########
core/src/test/java/org/apache/calcite/sql2rel/CorrelateProjectExtractorTest.java:
##########
@@ -84,6 +84,78 @@ public static Frameworks.ConfigBuilder config() {
assertThat(after, hasTree(planAfter));
}
+ /** Test case for <a
href="https://issues.apache.org/jira/browse/CALCITE-7646";>[CALCITE-7646]
+ * CorrelateProjectExtractor does not handle nested field accesses
cor0.field0.field1</a>. */
+ @Test void testNestedCorrelationFieldAccessInFilter() {
Review Comment:
The new logic returns null from `visitCall` for neutral subexpressions. The
Javadoc example `CASE(IS NOT NULL($cor0.PATH), $cor0.PATH, ARRAY(NULL))` seems
not covered by any test. can we add a test to verify that
constant/dynamic-parameter operands do not wrongly disqualify the enclosing
correlated call?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
