mihaibudiu commented on code in PR #5036:
URL: https://github.com/apache/calcite/pull/5036#discussion_r3604609405
##########
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java:
##########
@@ -546,26 +546,55 @@ public Result visit(Correlate e) {
null);
return result(join, leftResult, rightResult);
}
-
/** Visits a Filter; called by {@link #dispatch} via reflection. */
public Result visit(Filter e) {
final RelNode input = e.getInput();
+ final Set<CorrelationId> definedHere = e.getVariablesSet();
+
if (input instanceof Aggregate) {
final Aggregate aggregate = (Aggregate) input;
final boolean ignoreClauses = aggregate.getInput() instanceof Project;
- final Result x =
+ Result x =
visitInput(e, 0, isAnon(), ignoreClauses,
ImmutableSet.of(Clause.HAVING));
+ final boolean pushed = !definedHere.isEmpty()
+ && e.getInput().getInputs().size() <= 1;
+ if (pushed) {
+ String alias = x.neededAlias;
+ if (alias != null) {
+ x = x.resetAliasForCorrelation(alias, e.getInput().getRowType());
+ } else {
+ alias = unqualifiedName(x.node);
+ if (alias == null) {
+ alias = "t";
+ }
+ x = x.resetAliasForCorrelation
Review Comment:
Please re-request a review if you have a test for this.
While planning you can freely rename internal fields, but when you generate
the final code you have less freedom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
