xuzifu666 commented on code in PR #5113: URL: https://github.com/apache/calcite/pull/5113#discussion_r3619195304
########## core/src/test/resources/sql/offset.iq: ########## @@ -0,0 +1,186 @@ +# offset.iq +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to you under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +!use post +!set outputformat mysql Review Comment: Is there any relevant MySQL validation? You can explain that the accuracy of the results has been verified against relevant databases. ########## core/src/test/java/org/apache/calcite/test/enumerable/EnumerableMergeUnionTest.java: ########## @@ -176,16 +244,14 @@ class EnumerableMergeUnionTest { tester(false, new HrSchemaBig(), "select * from (select empid, name from emps where name like 'G%' union select empid, name from emps where name like '%l') order by name limit 3") - .explainContains("EnumerableLimit(fetch=[3])\n" + .explainContains("EnumerableLimitSort(sort0=[$1], dir0=[ASC], fetch=[3])\n" Review Comment: When modifying a large number of existing tests, it is best to provide a summary of the reasons to help other reviewers understand the situation more easily. ########## testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java: ########## @@ -4075,7 +4075,16 @@ void checkPeriodPredicate(Checker checker) { + "FROM `FOO`\n" + "OFFSET ? ROWS\n" + "FETCH NEXT ? ROWS ONLY"); - // CALCITE-7592: Arithmetic and scalar expressions are allowed within parentheses. Review Comment: Why is this comment being modified? Is it related to the associated Jira ticket? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
