mihaibudiu commented on code in PR #4828:
URL: https://github.com/apache/calcite/pull/4828#discussion_r3714984983
##########
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java:
##########
@@ -508,9 +508,13 @@ private boolean isCommaJoin(Join join) {
/** Visits a Correlate; called by {@link #dispatch} via reflection. */
public Result visit(Correlate e) {
+ final Result visitedLeft = visitInput(e, 0);
Review Comment:
This seems to make some cosmetic changes to the generated code, like using
t0 instead of $cor0.
Which one is the actual important semantic change?
Is this cosmetic change valuable, or can it be omitted (maybe it would make
comparing the changes in the new plans easier)?
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -12661,6 +12661,37 @@ public Sql schema(CalciteAssert.SchemaSpec schemaSpec)
{
sql(sql).schema(CalciteAssert.SchemaSpec.JDBC_SCOTT).ok(expected);
}
+ @Test void testPostgresqlRoundTripCorrelatedProjectWithSemiJoinRules() {
Review Comment:
Please follow the existing pattern for documenting this test using JavaDoc,
there are lots of examples.
No need to have a separate function for the SQL, just make it a final String.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
