wasabii commented on code in PR #5150:
URL: https://github.com/apache/calcite/pull/5150#discussion_r3716936189
##########
server/src/test/java/org/apache/calcite/test/ServerTest.java:
##########
@@ -241,6 +241,63 @@ static Connection connect() throws SQLException {
}
}
+ /** Tests that DELETE works on a single-column table.
+ *
+ * <p>A single-column table has SCALAR physical row format, so its Java row
+ * type is a primitive. The generated sink key extractor must not cast
+ * Object to that primitive directly: Java allows such a cast but Janino,
+ * which compiles the generated code, does not implement it. */
+ @Test void testDeleteSingleColumn() throws Exception {
Review Comment:
Added `testDeleteSingleObjectColumn`
##########
server/src/test/java/org/apache/calcite/test/ServerTest.java:
##########
@@ -241,6 +241,63 @@ static Connection connect() throws SQLException {
}
}
+ /** Tests that DELETE works on a single-column table.
+ *
+ * <p>A single-column table has SCALAR physical row format, so its Java row
+ * type is a primitive. The generated sink key extractor must not cast
+ * Object to that primitive directly: Java allows such a cast but Janino,
+ * which compiles the generated code, does not implement it. */
+ @Test void testDeleteSingleColumn() throws Exception {
Review Comment:
Added `testDeleteSingleObjectColumn`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
