xuzifu666 commented on code in PR #5173: URL: https://github.com/apache/calcite/pull/5173#discussion_r3754870098
########## core/src/test/resources/sql/agg.iq: ########## @@ -3842,6 +3842,36 @@ group by deptno; !ok +# [CALCITE-7706] ARG_MIN ignores nullability of second argument +# Rows whose comparator is NULL are skipped, so a group where every +# comparator value is NULL yields NULL even though the value argument +# is NOT NULL. +select g, arg_min(v, c) as r Review Comment: `agg.iq` only tested the runtime behavior of `ARG_MIN` and not `ARG_MAX`; although the logic is symmetrical, it would be good to add the missing test case（This revision also involves arg_max）. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
