mihaibudiu opened a new pull request, #5201: URL: https://github.com/apache/calcite/pull/5201
## Jira Link [CALCITE-7725](https://issues.apache.org/jira/browse/CALCITE-7725) ## Changes Proposed Checked arithmetic is marked as non-safe, since such operators can always throw. There's a visitor ConvertToChecked which converts unchecked arithmetic to checked arithmetic based on conformance. This was run in Prepare on the Rel representation. Turns out that SqlToRelConverter invokes `simplify` which makes some arithmetic simplifications which happen BEFORE this conversion. So I had to add a second invocation of this pass inside SqlToRelConverter, driven by the same conformance flag. (Both are necessary in general.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
