vlsi commented on code in PR #5213:
URL: https://github.com/apache/calcite/pull/5213#discussion_r3855559765
##########
druid/src/main/java/org/apache/calcite/adapter/druid/DruidConnectionImpl.java:
##########
@@ -97,7 +97,7 @@ class DruidConnectionImpl implements DruidConnection {
* @param page Page definition (in/out)
*/
public void request(QueryType queryType, String data, Sink sink,
- List<String> fieldNames, List<ColumnMetaData.Rep> fieldTypes,
+ List<String> fieldNames, List<ColumnMetaData.@Nullable Rep> fieldTypes,
Review Comment:
This might better be `List<? extends ColumnMetaData.@Nullable Rep>`,
however, AFAIK it changes public API signature, so it is not 100% backward
compatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
