1fanwang commented on code in PR #5222:
URL: https://github.com/apache/calcite/pull/5222#discussion_r3868875332
##########
core/src/test/java/org/apache/calcite/test/enumerable/EnumerableSortedAggregateTest.java:
##########
@@ -74,6 +74,40 @@ public class EnumerableSortedAggregateTest {
.throws_("There are not enough rules to produce a node with desired
properties");
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6089";>[CALCITE-6089]
+ * EnumerableSortedAggregate fails with ClassCastException: class X cannot be
+ * cast to class org.apache.calcite.runtime.FlatLists$ComparableList</a>.
+ *
+ * <p>The aggregate has no group key, so since
Review Comment:
Agreed, and that paragraph is already out. The revision after your review
cut the explanation of the old behaviour and left the Javadoc as the issue link
alone.
What the two tests assert now is current behaviour rather than history. One
shows the rule declining the plan when the aggregate has no group key, the
other shows the default rules producing the right count for the same query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
