mihaibudiu commented on code in PR #5240:
URL: https://github.com/apache/calcite/pull/5240#discussion_r3936954449
##########
core/src/main/java/org/apache/calcite/sql/validate/AggChecker.java:
##########
@@ -87,6 +88,14 @@ boolean isGroupExpr(SqlNode e) {
if (expr.equalsDeep(e, Litmus.IGNORE)) {
return true;
}
+ // A GROUP BY item may be a common column of a NATURAL/USING join that
Review Comment:
can equalsDeep match if this is an AsOperator?
If not, these two should be swapped and you can have only one call to
equalsDeep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
