mihaibudiu commented on code in PR #5255:
URL: https://github.com/apache/calcite/pull/5255#discussion_r3991310783
##########
core/src/main/java/org/apache/calcite/model/ModelHandler.java:
##########
@@ -227,7 +227,7 @@ public static void addFunctions(ClassNameFilter filter,
SchemaPlus schema,
filter.check(className);
final Class<?> clazz;
try {
- clazz = Class.forName(className);
+ clazz = Class.forName(className, false,
ModelHandler.class.getClassLoader());
Review Comment:
This is very subtle and requires a relatively deep knowledge of Java
classloaders. Can you add a comment explaining what it achieves and why it has
to be this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
