julianhyde commented on code in PR #5262:
URL: https://github.com/apache/calcite/pull/5262#discussion_r4007986089
##########
core/src/main/java/org/apache/calcite/interpreter/UncollectNode.java:
##########
@@ -61,16 +61,16 @@ public UncollectNode(Compiler compiler, Uncollect
uncollect) {
}
}
} else if (value instanceof Map) {
- Map map = (Map) value;
+ Map<?, ?> map = (Map<?, ?>) value;
if (map.isEmpty() && rel.isOuter) {
sink.send(Row.of(new Object[width]));
continue;
}
- for (Object key : map.keySet()) {
+ for (Map.Entry<?, ?> entry : map.entrySet()) {
Review Comment:
`Map.forEach(BiConsumer)` may be more efficient here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
