amaechler opened a new pull request, #321:
URL: https://github.com/apache/calcite-avatica/pull/321

   Fixes [CALCITE-7796](https://issues.apache.org/jira/browse/CALCITE-7796).
   
   This PR sets the hostname verification policy explicitly using the 
three-argument constructor that exists since HttpClient 5.4:
   
   * `NONE` uses `HostnameVerificationPolicy.CLIENT` with 
`NoopHostnameVerifier`, so no hostname check runs.
   * `STRICT` (the default) uses `HostnameVerificationPolicy.BOTH` with the 
default verifier. This keeps the HttpClient verifier that ran before and 
additionally enables the JSSE check, which is what HttpClient 5.6 does by 
default.
   
   I didn't update the httpclient5 in this PR, since the fix compiles and 
behaves the same on 5.5 (where there is no bug). I verified 
`SslHostnameVerificationTest` against both versions locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to