rubenada opened a new pull request, #5286: URL: https://github.com/apache/calcite/pull/5286
<!-- Thanks for sending a pull request! Here are some critical tips for you: 1. READ THE GUIDE FIRST: https://calcite.apache.org/develop/#contributing *For significant contributions, please discuss on the dev mailing list or Jira BEFORE coding.* 2. JIRA IS USUALLY MANDATORY: Ensure you have created an issue on the Calcite Jira: https://issues.apache.org/jira/projects/CALCITE/issues *Check existing issues first to avoid duplicates.* *Note: A Jira is NOT required for typos and cosmetic changes (i.e., changes that are neither bugs nor features).* 3. TIMING: Strongly recommended to create the Jira BEFORE you start writing code (e.g., a day or so before posting a PR). This gives others a chance to weigh in on your specification. 4. CRITICAL CONSISTENCY RULE The following three items MUST match exactly in wording and meaning: (A) The Jira Issue Title (B) This Pull Request Title (C) Your Git Commit Message Format: [CALCITE-XXXX] <Description> Example: [CALCITE-0000] Add IF NOT EXISTS clause to CREATE TABLE Guidelines for a good Title: - Illustrate using SQL keywords (in ALL-CAPS) rather than Java method names. - Focus on the specification and user experience, not the implementation. - Make it clear whether it is a bug or a feature. - Use words like "should" to indicate desired behavior vs. current behavior (e.g., "Validator should not close model file"). 5. REPRODUCTION: If fixing a bug, please provide a concise SQL example or test case to reproduce the issue for a faster review. 6. TESTING: Ensure `./gradlew build` passes and appropriate tests are added/updated. --> ## Jira Link [CALCITE-739](https://issues.apache.org/jira/browse/CALCITE-739) ## Changes Proposed <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. If possible, please consider writing useful notes for better and faster reviews in your PR. --> The original patch for CALCITE-739 (51e6cb1) implemented some extra factoring, but it also (unnecessarily) may alter the "orientation" of comparison predicates. This can have a certain impact on downstream projects which verify plan forms, e.g. in Hive we detected 150+ tests that fail simply because they expect `$a=$b` and now they get `$b=$a`. With some minor adjustments, we should be able to maintain the new feature of extra factoring `RexUtil.pullFactors` without changing unnecessarily the authored orientation of certain predicates: - drop `default: return normalizeComparison(rex);` in `pull()` (`RexUtil.java:2970`): it does no factoring at all, it is pure canonicalization - in `commonFactors`, store the original as the value: `map.put(normalized, conjunction`) rather than `map.put(normalized, normalized)`, so pulled-out factors keep their authored orientation These changes will reduce the side effects of the original commit (facilitating the eventual upgrade to 1.43 for downstream projects that test plan shape), keeping the improvement of CALCITE-739 (see specific test RexProgramTest#testSimplifyComparisonSymmetry still passes with the proposed adjustment). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
