ehds commented on PR #5288: URL: https://github.com/apache/calcite/pull/5288#issuecomment-5832654238
> * A SQL-level test for the TUMBLE case from the Jira would match the shape of the neighboring tests (`sql(...).toRel()`). @vlsi Thanks for the thorough review. As you pointed out, other operators don’t account for sub-queries in their expressions, and Correlate isn’t handled either, so I think a separate Jira makes sense. I’ve removed the RexSubQuery handling from this PR and updated the Javadocs and tests based on your feedback. @zzwqqq @mihaibudiu what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
