mihaibudiu commented on code in PR #5297:
URL: https://github.com/apache/calcite/pull/5297#discussion_r4128589985
##########
core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java:
##########
@@ -755,6 +755,16 @@ private RelDataType getTightestCommonTypeOrThrow(
return null;
}
+ /**
+ * Returns the common type for comparing an approximate numeric with an
+ * exact numeric. Default: keep the approximate type. Override to widen to
Review Comment:
do not add comments about 7827 in this API
##########
core/src/test/java/org/apache/calcite/test/TypeCoercionTest.java:
##########
@@ -484,6 +486,45 @@ private static ImmutableList<RelDataType> combine(
f.recordType("a", f.arrayType(f.nullableIntType)));
}
+ /**
+ * Default: DECIMAL vs. REAL/FLOAT narrows to REAL/FLOAT, same as
Review Comment:
isn't this test covered by existing cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
