sbroeder commented on code in PR #5271:
URL: https://github.com/apache/calcite/pull/5271#discussion_r4138944475


##########
core/src/main/java/org/apache/calcite/sql/SqlUnnestOperator.java:
##########
@@ -130,6 +127,15 @@ public SqlUnnestOperator(boolean withOrdinality) {
     return builder.build();
   }
 
+  /**
+   * Returns whether UNNEST expands {@code componentType} into one column
+   * per field, rather than a single column of the struct's own type.
+   */
+  public static boolean expandsStructIntoColumns(RelDataType componentType,
+      boolean allowAliasUnnestItems) {
+    return componentType.isStruct() && !allowAliasUnnestItems;
+  }

Review Comment:
   All addressed: marked both new static helpers @API(since = "1.43", status = 
API.Status.INTERNAL), added the @param docs, and fixed the wording so it 
doesn't imply a struct-only outcome.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to