tkalkirill commented on code in PR #5306:
URL: https://github.com/apache/calcite/pull/5306#discussion_r4187934611
##########
core/src/test/java/org/apache/calcite/test/SqlFunctionsTest.java:
##########
@@ -117,6 +117,55 @@ static <E> List<E> list() {
return ImmutableList.of();
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-7837";>[CALCITE-7837]
+ * ARRAY_MIN, ARRAY_MAX and SORT_ARRAY throw ClassCastException for ROW
elements</a>. */
+ @Test void testArrayComparisonWithSpecialFloatingPointValues() {
Review Comment:
These tests don't exercise ROW values directly. They check that the fix
preserves existing behavior for scalar arrays, particularly NaN and infinities,
to guard against regressions. ROW values are covered by the adjacent test. If
you think this additional coverage is unnecessary, I'm remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
