mihaibudiu commented on code in PR #5304:
URL: https://github.com/apache/calcite/pull/5304#discussion_r4189817342
##########
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##########
@@ -439,7 +439,7 @@ private static int findLiteralIndex(List<RexNode> operands,
BigDecimal value) {
}
/** Check whether the operand is a BigDecimal literal of the specified
value. */
- private static boolean checkLiteralValue(RexNode operand, BigDecimal value) {
+ public static boolean checkLiteralValue(RexNode operand, BigDecimal value) {
Review Comment:
Yes, this is called "code reuse".
Maybe there will be more callers now that it's public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
